Make structured buffers illegal parameter types in WGSL #5483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csyonghe
reviewed
Nov 4, 2024
aleino-nv
force-pushed
the
aleino/wgpu
branch
from
fa9187b to
0221e73
Compare
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
aleino-nv
added a commit
to aleino-nv/slang
that referenced
this pull request
Nov 5, 2024
Format code for PR shader-slang#5483
expipiplus1
previously approved these changes
Nov 5, 2024
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
aleino-nv
added a commit
to aleino-nv/slang
that referenced
this pull request
Nov 6, 2024
Format code for PR shader-slang#5483
aleino-nv
force-pushed
the
aleino/wgpu
branch
from
70fda35 to
765b0c1
Compare
…targeting WGSL Structured buffer types translate to array types in the WGSL emitter. WGSL doesn't allow passing runtime-sized arrays to functions. Similarly for pointers to texture handles. Also, structured buffers (runtime-sized arrays) cannot be returned in WGSL. This closes issue shader-slang#5228, issue shader-slang#5278 and issue shader-slang#5288 by enabling specialized functions to be generated in these cases, in order to work around these constraints.
aleino-nv
force-pushed
the
aleino/wgpu
branch
from
765b0c1 to
9790c3e
Compare
csyonghe
approved these changes
Nov 6, 2024
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Structured buffer types translate to array types in the WGSL emitter. WGSL doesn't allow passing runtime-sized arrays to functions.
This closes issue #5228.