Open existential on arguments after overload resolution. #4982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArielG-NV
previously approved these changes
Sep 4, 2024
Co-authored-by: ArielG-NV <[email protected]>
ArielG-NV
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4467.
The problem revealed here is that in
ResolveInvokewe are performingopenExistentialon arguments before resolving overloaded callees. This is needed in order to correctly resolve generic arguments for generic callees. However we can't always us the opened existential value as argument if the parameter is mutable.So the fix here is to switch back to original argument expr after an overload candidate is picked and we can figure out the corresponding parameter is a mutable one.