-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated MDL shader sources for benchmarks #4965
Merged
venkataram-nv
merged 7 commits into
shader-slang:master
from
venkataram-nv:updated-benchmark-shaders
Aug 30, 2024
Merged
Updated MDL shader sources for benchmarks #4965
venkataram-nv
merged 7 commits into
shader-slang:master
from
venkataram-nv:updated-benchmark-shaders
Aug 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwak-work
reviewed
Aug 29, 2024
venkataram-nv
force-pushed
the
updated-benchmark-shaders
branch
from
August 29, 2024 20:10
465b831
to
ebd96ee
Compare
venkataram-nv
force-pushed
the
updated-benchmark-shaders
branch
from
August 29, 2024 22:26
ebd96ee
to
921f4ec
Compare
venkataram-nv
force-pushed
the
updated-benchmark-shaders
branch
from
August 29, 2024 23:05
4ba47a3
to
258df57
Compare
I think you need to modify |
jkwak-work
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new benchmarking script will checkout the shader-slang MDL-SDK fork and then run only one sample instead of sixteen, to reduce the time taken by the workflow. The plan is for only the commits to master to run the full sixteen samples when pushing to the results page.