Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MDL shader sources for benchmarks #4965

Merged

Conversation

venkataram-nv
Copy link
Collaborator

@venkataram-nv venkataram-nv commented Aug 29, 2024

The new benchmarking script will checkout the shader-slang MDL-SDK fork and then run only one sample instead of sixteen, to reduce the time taken by the workflow. The plan is for only the commits to master to run the full sixteen samples when pushing to the results page.

@venkataram-nv venkataram-nv self-assigned this Aug 29, 2024
@venkataram-nv venkataram-nv added the pr: non-breaking PRs without breaking changes label Aug 29, 2024
@venkataram-nv venkataram-nv force-pushed the updated-benchmark-shaders branch from 465b831 to ebd96ee Compare August 29, 2024 20:10
@venkataram-nv venkataram-nv marked this pull request as ready for review August 29, 2024 20:15
@venkataram-nv venkataram-nv force-pushed the updated-benchmark-shaders branch from ebd96ee to 921f4ec Compare August 29, 2024 22:26
@venkataram-nv venkataram-nv force-pushed the updated-benchmark-shaders branch from 4ba47a3 to 258df57 Compare August 29, 2024 23:05
@jkwak-work
Copy link
Collaborator

I think you need to modify .gitmodules to include a new MDL repo after it is properly moved to shader-slang organization.

Copy link
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@venkataram-nv venkataram-nv merged commit 49862e7 into shader-slang:master Aug 30, 2024
12 checks passed
@venkataram-nv venkataram-nv deleted the updated-benchmark-shaders branch August 30, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants