Allow capabilities to be used with [shader("...")]
#4928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: shader-slang#4917 Changes: 1. Allow using capabilities instead of `Stage`s with `EntryPointAttribute`. 2. When resolving capabilities for an entrypoint+profile (per entrypoint) in `resolveStageOfProfileWithEntryPoint` add our `EntryPointAttribute` and resolved capability 3. Added tests and some capabilities related clean-up
…Attribute-modifier
…ifier' of https://github.com/ArielG-NV/slang into allow-capabilities-for-use-with-EntryPointAttribute-modifier
…and 'Profile' This use case is why we need to clean all profile-usage into `CapabilityName`s directly.
…Attribute-modifier
…ifier' of https://github.com/ArielG-NV/slang into allow-capabilities-for-use-with-EntryPointAttribute-modifier
csyonghe
previously approved these changes
Aug 28, 2024
| alias callable = _callable + raytracing; | ||
| alias miss = _miss + raytracing; | ||
|
|
||
| alias mesh = _mesh + meshshading_internal; |
There was a problem hiding this comment.
Should it be _meshshading_internal?
There was a problem hiding this comment.
The capability should be renamed👍
I think we can just do _meshshading since this capability pairs with meshshading.
csyonghe
approved these changes
Aug 28, 2024
…Attribute-modifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4917
Changes:
Stages withEntryPointAttribute.resolveStageOfProfileWithEntryPointadd ourEntryPointAttributecapabilities.Note: due to 'Profile' still being used internally we cannot pass
EntryPointAttributecapabilities to IR (and require spirv versions usingEntryPointAttribute), related to #4421