Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a false failure when using the latest SPIR-V #4904

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Fix a false failure when using the latest SPIR-V #4904

merged 3 commits into from
Aug 22, 2024

Conversation

jkwak-work
Copy link
Collaborator

@jkwak-work jkwak-work commented Aug 21, 2024 •
edited
Loading

With the current SPIR-V, the test emits the following,

; Annotations
OpDecorate %8 Flat

; Types, variables and constants
%8 = OpVariable %_ptr_Input_int Input

With the latest SPIR-V, the same test emits the following with an additional comment,

; Annotations
OpDecorate %8 Flat

; Types, variables and constants
%8 = OpVariable %_ptr_Input_int Input ; Location 0, Flat

This results in a false failure where it is not a real failure.

@jkwak-work jkwak-work added the pr: non-breaking PRs without breaking changes label Aug 21, 2024
@jkwak-work jkwak-work requested a review from ArielG-NV August 21, 2024 22:49
@jkwak-work jkwak-work self-assigned this Aug 21, 2024
@jkwak-work jkwak-work force-pushed the fix/resolve_false_failure_after_updating_spirv branch from ba0f732 to 4d7c932 Compare August 21, 2024 22:53
ArielG-NV
ArielG-NV previously approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@ArielG-NV ArielG-NV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 suggestion.
Code looks good.

@jkwak-work jkwak-work force-pushed the fix/resolve_false_failure_after_updating_spirv branch from 4d7c932 to b9c55e4 Compare August 21, 2024 23:25
ArielG-NV
ArielG-NV previously approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@ArielG-NV ArielG-NV left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 1 suggestion (CHECK-DAG over CHECK).
Code changes look good.

@jkwak-work jkwak-work merged commit a3fbd8f into shader-slang:master Aug 22, 2024
12 checks passed
@jkwak-work jkwak-work deleted the fix/resolve_false_failure_after_updating_spirv branch August 22, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@expipiplus1 expipiplus1 expipiplus1 approved these changes

@ArielG-NV ArielG-NV ArielG-NV left review comments

Assignees

@jkwak-work jkwak-work

Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkwak-work @expipiplus1 @ArielG-NV