Fix the invalid spirv generation for matrix cast #4588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Were you able to reproduce the validation error locally without upgrading the vulkan sdk version? |
|
This PR will close #4589. |
Yes, I can. And now the issue is gone with this change. |
jkwak-work
reviewed
Jul 10, 2024
Comment on lines
50
to
53
| $ErrorActionPreference = "SilentlyContinue" | ||
| where.exe spirv-dis | ||
| spirv-dis --version | ||
| $env:SLANG_RUN_SPIRV_VALIDATION='1' |
There was a problem hiding this comment.
I don't think we need this change anymore.
The file "windows-selfhosted.yml" is delete at ToT.
The same functionality is implemented in ci.yml, which sets SLANG_RUN_SPIRV_VALIDATION correctly.
There was a problem hiding this comment.
Ok, I can remove this file from this change.
Spirv doesn't have instruction to do the float cast for the matrix type. So we have to convert the matrix row by row, and then construct them to a new matrix. Update the unit test to make sure the cast won't miss any elements.
kaizhangNV
force-pushed
the
issue/maxtrix_float_convert
branch
from
f610eec to
3721ef3
Compare
|
I rebase on TOT and remove the |
csyonghe
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spirv doesn't have instruction to do the float cast for the matrix type. So we have to convert the matrix row by row, and then construct them to a new matrix.
Update the unit test to make sure the cast won't miss any elements.
Also update the workflow to validate the spirv generation.