Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from ubuntu-18 to centos-7 build #4496

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

kaizhangNV
Copy link
Contributor

No description provided.

@kaizhangNV kaizhangNV added the pr: non-breaking PRs without breaking changes label Jun 27, 2024
@kaizhangNV kaizhangNV force-pushed the centos-7-build branch 2 times, most recently from dcf54db to f35df92 Compare June 27, 2024 17:20
@jkwak-work
Copy link
Collaborator

Why are we switching it and what are the differences?
Is there an issue number for this?

@kaizhangNV
Copy link
Contributor Author

Why are we switching it and what are the differences? Is there an issue number for this?

The libstdc++ version doesn't match. The issue is internal.

@kaizhangNV kaizhangNV force-pushed the centos-7-build branch 4 times, most recently from 5b8afb3 to f6458a7 Compare June 27, 2024 17:47
@jkwak-work
Copy link
Collaborator

Shouldn't we be adding one more CI for the new OS instead of switching from one we have been using?
Do we have another CI coverage on Ubuntu-18?

@kaizhangNV kaizhangNV force-pushed the centos-7-build branch 6 times, most recently from b0c1887 to d8cbcf1 Compare June 27, 2024 20:50
@kaizhangNV kaizhangNV changed the title WIP: switch from ubuntu-18 to centos-7 build switch from ubuntu-18 to centos-7 build Jun 27, 2024
@kaizhangNV kaizhangNV merged commit 8172751 into shader-slang:master Jun 27, 2024
17 checks passed
kaizhangNV added a commit that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants