Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade github/actions/upload-artifact and download-artifact to version 4 #6050

Closed
jkwak-work opened this issue Jan 9, 2025 · 0 comments · Fixed by #6051
Closed

Upgrade github/actions/upload-artifact and download-artifact to version 4 #6050

jkwak-work opened this issue Jan 9, 2025 · 0 comments · Fixed by #6051
Assignees
@jkwak-work
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang

Comments

@jkwak-work
Copy link
Collaborator

Github has warned us for the deprecation of version 3 of upload-artifact and download-artifact.
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

According to the announcement, the deprecation is supposed to be effective from Jan/31/2025.
But we are seeing error messages on ci.yml like following,

Current runner version: '2.321.0'
Operating System
Runner Image
Runner Image Provisioner
GITHUB_TOKEN Permissions
Secret source: None
Prepare workflow directory
Prepare all required actions
Getting action download info
Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v3`. Learn more: https://github.blog/changelog/[2](https://github.com/shader-slang/slang/actions/runs/12695233437/job/35388297451#step:1:2)024-04-16-deprecation-notice-v3-of-the-artifact-actions/

https://github.com/shader-slang/slang/actions/runs/12695233437/job/35388297451

We should upgrade them soon.
@jkwak-work jkwak-work added the goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang label Jan 9, 2025
@jkwak-work jkwak-work self-assigned this Jan 9, 2025
jkwak-work added a commit to jkwak-work/slang that referenced this issue Jan 9, 2025
@jkwak-work
Upgrade actions/upload-artifact from v3 to v4
a5c3a21 
The version 3 of actions/upload-artifact will be deprecated soon.
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

This commit upgrades to v4.
There is a document describing how to migrate/upgrade:
https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

The breaking change on v4 is that the uploaded files are immutable and
we can no longer append files with the same name. We don't seem to be
doing it so it should be fine for us.

Closes shader-slang#6050
@jkwak-work jkwak-work mentioned this issue Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkwak-work jkwak-work

Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade actions/upload-artifact from v3 to v4 jkwak-work/slang
1 participant
@jkwak-work