Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all intrinsic fails codegen on cuda and spirv #4531

Closed
expipiplus1 opened this issue Jul 2, 2024 · 3 comments
Closed

all intrinsic fails codegen on cuda and spirv #4531

expipiplus1 opened this issue Jul 2, 2024 · 3 comments
Assignees
@expipiplus1
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang
Milestone
Q3 2024 (Summer)

Comments

@expipiplus1
Copy link
Collaborator

expipiplus1 commented Jul 2, 2024 •
edited
Loading

blocking #4529
@expipiplus1 expipiplus1 self-assigned this Jul 2, 2024
@bmillsNV bmillsNV added the goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang label Jul 2, 2024
@bmillsNV bmillsNV added this to the Q3 2024 (Summer) milestone Jul 2, 2024
@expipiplus1
Copy link
Collaborator Author

  • fails on cuda because we emit the non-existent bool4 type
  • fails on glsl when used with bool1 because we generate the poorly typed call to all with a bool argument instead of bool1, and the glsl snippet fails to extract the length

expipiplus1 added a commit to expipiplus1/slang that referenced this issue Jul 3, 2024
@expipiplus1
Add specializations for 1 vectors in functions using the $N glsl intr…
1d8a12d 
…insic placement

Closes shader-slang#4533
Fixes part of shader-slang#4531
@expipiplus1 expipiplus1 mentioned this issue Jul 3, 2024
Merged
expipiplus1 added a commit that referenced this issue Jul 5, 2024
@expipiplus1
Add specializations for 1 vectors in functions using the $N glsl intr…
40a4022 
…insic placement (#4534)

Closes #4533
Fixes part of #4531
@expipiplus1
Copy link
Collaborator Author

Related to #4386

@expipiplus1
Copy link
Collaborator Author

Fixed for glsl by 40a4022 and cuda by 639576c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@expipiplus1 expipiplus1

Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang
Projects
None yet
Milestone
Q3 2024 (Summer)
Development

No branches or pull requests
2 participants
@expipiplus1 @bmillsNV