Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capability System: [require(....)] never checks if the capabilities required are invalid #4506

Closed
ArielG-NV opened this issue Jun 28, 2024 · 0 comments · Fixed by #4510
Closed

Capability System: [require(....)] never checks if the capabilities required are invalid #4506

ArielG-NV opened this issue Jun 28, 2024 · 0 comments · Fixed by #4510
Assignees
@ArielG-NV
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:bug something doesn't work like it should

Comments

@ArielG-NV
Copy link
Contributor

Problem:
[require(hlsl, glsl)] is allowed despite being Invalid

Solution:
This should be an error.
@ArielG-NV ArielG-NV added kind:bug something doesn't work like it should goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang labels Jun 28, 2024
@ArielG-NV ArielG-NV self-assigned this Jun 28, 2024
ArielG-NV added a commit to ArielG-NV/slang that referenced this issue Jun 28, 2024
@ArielG-NV
Fix invalid capabilities being allowed
c9921ba 
fixes: shader-slang#4506
fixes: shader-slang#4508

1. As per shader-slang#4506, no longer allow invalid `[require(...)]`
2. As per shader-slang#4508, no longer allow mismatch between `case` and `require` of a calling function
3. Fixes incorrect hlsl.meta capabilities
4. Added a ref to the parent function/decl for when erroring with capabilities to help debug meta.slang files for when weird source locations are generated.
@ArielG-NV ArielG-NV mentioned this issue Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArielG-NV ArielG-NV

Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:bug something doesn't work like it should
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Emit errors when invalid capabilities are used ArielG-NV/slang
1 participant
@ArielG-NV