feat(frontend/settings): add os.release to about page and sentry logger #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhajneet
changed the title
Harjot1Singh
approved these changes
May 29, 2020
|
@bhajneet I'll leave it up to you if you'd like to do this now, but it might be worth sending this information to sentry too - see |
|
That's a good idea, I'll convert this to a draft for now |
bhajneet
changed the title
Harjot1Singh
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of PR
Add release info to about page, this info can also be used in loggers so logs will reflect which os is running more effectively
Tests for unexpected behavior
Time spent on PR
13 mins of reading docs, 1 minute of coding, 1 minute of PR = 15 mins
Linked issues
Fix #365
Reviewers
@Harjot1Singh