feat(frontend/settings): refresh overlay dropdown on focus #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhajneet
changed the title
Co-Authored-By: Harjot1Singh <[email protected]> refactor: remove console logs
…pdown component Co-Authored-By: Harjot1Singh <[email protected]>
Harjot1Singh
approved these changes
May 30, 2020
Harjot1Singh
approved these changes
May 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of PR
A new component that
onOpenwill fetch list of available themes from server.Tests for unexpected behavior
Before: restart ShabadOS to load overlay themes
After
Time spent on PR
~3 hours
Linked issues
Closes #448
Reviewers
@Harjot1Singh
Need to fix this and then should be good to go:
TypeError: cyclic object value.