Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last word repeating in search results #569

Closed
saihaj opened this issue May 30, 2020 · 4 comments · Fixed by #594
Closed

Last word repeating in search results #569

saihaj opened this issue May 30, 2020 · 4 comments · Fixed by #594
Labels
Scope: Frontend/Controller ○ Type Bug Regressions/production issues that do not function as intended.

Comments

@saihaj
Copy link
Member

saihaj commented May 30, 2020

Describe the bug
When transliterations are turned on for search results. Last word is repeated twice.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Settings'
  2. Click on 'Activities' > 'Search'
  3. Select 'English' in 'Transliterations'
  4. Go back to controller and search 'qq'
  5. See the last word is repeated for everything

Screenshots
image

Specs

  • Version: Dev branch head at 0a990ac
@saihaj saihaj added Status: ? ? ? ○ Type Bug Regressions/production issues that do not function as intended. labels May 30, 2020
@sarabveer
Copy link

Aren't the transliterations being fetched from the DB? Are they being done on the fly?

@saihaj
Copy link
Member Author

saihaj commented May 30, 2020 •
edited
Loading

Aren't the transliterations being fetched from the DB?

DB is correct something done wrong on frontend.

Are they being done on the fly?

Yes

@saihaj saihaj added Scope: Frontend/Controller Status: ? ? ? ○ Type Bug Regressions/production issues that do not function as intended. and removed Status: ? ? ? ○ Type Bug Regressions/production issues that do not function as intended. labels May 30, 2020
@saihaj
Copy link
Member Author

saihaj commented May 30, 2020

#567 Related to this since matching translit has issues.
image

@saihaj
Copy link
Member Author

saihaj commented Jun 17, 2020

image

@saihaj saihaj mentioned this issue Oct 26, 2020
Merged
1 task
Harjot1Singh added a commit that referenced this issue Oct 26, 2020
@saihaj @Harjot1Singh
fix(frontend/controller): improve match highlighting + split up the s…
4b2c3b5 
…earch component (#594)

Fixes #567
Fixes #569

Co-authored-by: Saihajpreet Singh <[email protected]>
Co-authored-by: Harjot Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Scope: Frontend/Controller ○ Type Bug Regressions/production issues that do not function as intended.
Projects
None yet
Milestone
No milestone
3 participants
@Harjot1Singh @sarabveer @saihaj