Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe area not being used properly in landscape view #262

Open
bhajneet opened this issue Jan 24, 2022 · 5 comments
Open

Safe area not being used properly in landscape view #262

bhajneet opened this issue Jan 24, 2022 · 5 comments
Labels
○ Type Bug Regressions/production issues that do not function as intended.

Comments

@bhajneet
Copy link
Member

bhajneet commented Jan 24, 2022

Describe the bug

IMG_3192

As you can see here (this is just one example of many), the bottom bar containing the search bar and bookmarks button are squished inwards to respect the iPhone notch area on either side. Things that are disrespecting the safe area:

  • Main content (where gurbani, translations, etc are)
  • Top bar (where timeline/settings button and logo are)
  • Modals (both titlebar and modal content are not respecting the sides)

The above examples need to be squished in just like the bottom bar.

These also need to be tested on Android.

@bhajneet bhajneet added the ○ Type Bug Regressions/production issues that do not function as intended. label Jan 24, 2022
@Harjot1Singh Harjot1Singh moved this from Triage to Ready for Development in Project Management Mar 6, 2022
@Harjot1Singh Harjot1Singh moved this to Triage in Project Management Mar 6, 2022
Repository owner moved this from Ready for Development to In Testing in Project Management Mar 15, 2022
@bhajneet
Copy link
Member Author

Top bar height is wrong, makes hitting buttons difficult.

Search and Collections were not implemented:

  • search's "cancel" can't be clicked
  • search's search bar is overflowing height wise from where top bar ends
  • collection's content items are in danger zone
  • main, search, and collection top bars are all too small

@bhajneet bhajneet reopened this Mar 16, 2022
Repository owner moved this from In Testing to Ready for Development in Project Management Mar 16, 2022
@Harjot1Singh
Copy link
Member

What do you mean by top bar?

@bhajneet
Copy link
Member Author

What do you mean by top bar?

It's too short, very evident by the size of the search bar input overflowing

@Harjot1Singh
Copy link
Member

Hm, would we be able to compare it to a native horizontal bar? I believe it's using that as the the height and I can't seem to configure it. WIll have to look into other solutions.

@Harjot1Singh
Copy link
Member

So for horizontal, these are the defaults popping out of react navigation and I'm not how to solve it without switching back to the stack navigator (not native). If we do that, we may have to figure out how to get the full height pull to dismiss working again as that does not come OOTB. Will evaluate and revisit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
○ Type Bug Regressions/production issues that do not function as intended.
Projects
Status: Ready for Development
Development

No branches or pull requests

2 participants