-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safe area not being used properly in landscape view #262
Comments
Top bar height is wrong, makes hitting buttons difficult. Search and Collections were not implemented:
|
What do you mean by top bar? |
It's too short, very evident by the size of the search bar input overflowing |
Hm, would we be able to compare it to a native horizontal bar? I believe it's using that as the the height and I can't seem to configure it. WIll have to look into other solutions. |
So for horizontal, these are the defaults popping out of react navigation and I'm not how to solve it without switching back to the stack navigator (not native). If we do that, we may have to figure out how to get the full height pull to dismiss working again as that does not come OOTB. Will evaluate and revisit. |
Describe the bug
As you can see here (this is just one example of many), the bottom bar containing the search bar and bookmarks button are squished inwards to respect the iPhone notch area on either side. Things that are disrespecting the safe area:
The above examples need to be squished in just like the bottom bar.
These also need to be tested on Android.
The text was updated successfully, but these errors were encountered: