-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requiring default props specified as ES6 #113
Comments
saihaj
added
□ Type Story
Feature or requirement written from the user's perspective using non-technical language.
and removed
□ Type Story
Feature or requirement written from the user's perspective using non-technical language.
labels
Sep 17, 2020
saihaj
added a commit
to saihaj/ShabadOSmobile
that referenced
this issue
Sep 17, 2020
saihaj
added a commit
to saihaj/ShabadOSmobile
that referenced
this issue
Sep 18, 2020
Harjot1Singh
pushed a commit
that referenced
this issue
Sep 24, 2020
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
React is deprecating defaultProps on functional components and suggests to use ES6 default values (facebook/react#16210).
In order to stay future proof we will be disabling eslint rule for default props and continue with default values. But eslint can't throw error if we haven't specified a default value (where needed) and that depends when
eslint-plugin-react
resolves jsx-eslint/eslint-plugin-react#2396Describe the solution you'd like
Update eslint config once that feature is released.
Additional context
https://twitter.com/dan_abramov/status/1133878326358171650?s=20
Checkout discussion on Slack
The text was updated successfully, but these errors were encountered: