Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json_encode removed #391

Merged
merged 1 commit into from
Nov 25, 2015
Merged

json_encode removed #391

merged 1 commit into from
Nov 25, 2015

Conversation

nicolasdanelon
Copy link

cleanup: remove json_encode() (built-in since PHP 5.2)
See http://php.net/manual/en/function.json-encode.php

@ArthurHoaro ArthurHoaro added cleanup code cleanup and refactoring ok to merge labels Nov 24, 2015
@ArthurHoaro
Copy link
Member

Never saw that! :-o

@virtualtam virtualtam mentioned this pull request Nov 24, 2015
43 tasks
@virtualtam virtualtam added this to the 0.6.1 milestone Nov 24, 2015
@nicolasdanelon
Copy link
Author

hmmmm yeah.. it's a lot of code in that file, I don't understand everything... It's like a super model mixed with a controller, right? ahaha. I've try to create a Auth class.. but not success :/

@virtualtam
Copy link
Member

Thanks!
Could you update the commit message to:

cleanup: remove json_encode() (built-in since PHP 5.2)

See http://php.net/manual/en/function.json-encode.php

?

@nicolasdanelon
Copy link
Author

done, I think

@ArthurHoaro
Copy link
Member

git commit --amend
git push <remote> patch-1 --force

See http://php.net/manual/en/function.json-encode.php

Legacy since php 5.2.x . If php5.3 is required for the install script
ArthurHoaro added a commit that referenced this pull request Nov 25, 2015
@ArthurHoaro ArthurHoaro merged commit 986afb7 into shaarli:master Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup and refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants