Keep private links number … private.

[thican]

I guess the title is self explanatory.

IMHO, this value should not be seen for public, unless this is an open instance and therefore, no logged is kind of already logged in.

[thican]

I think it should be integrated for milestone 0.14.0, as raised in discussion #2105.

[nodiscc]

It is still easy to determine the number of private shaares by substracting the number of visible shaares, from the total shaares counter

        $this->assignView('linkcount', $this->container->bookmarkService->count(BookmarkFilter::$ALL));
        $this->assignView('privateLinkcount', $this->container->bookmarkService->count(BookmarkFilter::$PRIVATE));

A better approach would be displaying only the count of public shaares.

Anyway this doesn't hurt, so approving

[thican]

It is still easy to determine the number of private shaares by substracting the number of visible shaares, from the total shaares counter

        $this->assignView('linkcount', $this->container->bookmarkService->count(BookmarkFilter::$ALL));
        $this->assignView('privateLinkcount', $this->container->bookmarkService->count(BookmarkFilter::$PRIVATE));

A better approach would be displaying only the count of public shaares.

Oh you’re totally right, I didn’t notice this issue.
Yes this was my objective, only displaying those public ones.

Anyway this doesn't hurt, so approving

Please don’t merge until I (or anybody) fix this for only those public shaares number.

[thican]

@nodiscc Done.

I allowed myself to display the number of links, whether total, private & public, even if 0, instead of masking the information.

[thican]

I noticed there is translation feature, no idea if it was required and how to actually update, so my modifications are flawed as I copied them (without the total word that I added).