Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2084: Ensure tags are unique when renaming #2086

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

kcaran
Copy link

@kcaran kcaran commented May 14, 2024

#2084 - If a bookmark already includes the tag that the old tag is being renamed to, effectively merge the tags by removing the old and keeping the new. Previously, the new tag would be duplicated.

@nodiscc nodiscc added bug it's broken! in review labels May 15, 2024
@nodiscc nodiscc added this to the 0.14.0 milestone May 15, 2024
@nodiscc nodiscc self-requested a review May 15, 2024 16:50
@nodiscc nodiscc requested review from nodiscc and removed request for nodiscc October 18, 2024 19:41
@nodiscc nodiscc modified the milestones: 0.14.0, 0.15.0 Nov 15, 2024
@nodiscc nodiscc self-requested a review November 15, 2024 18:27
@nodiscc nodiscc dismissed their stale review November 15, 2024 18:28

old review

Copy link
Member

@nodiscc nodiscc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, thank you

@nodiscc nodiscc merged commit 3ba5297 into shaarli:master Nov 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug it's broken! in review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants