Remove 'updates.check_updates_branch' setting #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always use 'release' branch instead. Also treat commit hash as dev version Fixes shaarli#1966
ArthurHoaro
force-pushed
the
remove-version-check-branch
branch
from
14f1ac8 to
379ab59
Compare
nodiscc
reviewed
Apr 11, 2023
| @@ -63,7 +63,6 @@ | |||
| }, | |||
| "updates": { | |||
| "check_updates": false, | |||
| "check_updates_branch": "stable", | |||
There was a problem hiding this comment.
I think updateMethodCheckUpdateRemoteBranch() in application/legacy/LegacyUpdater.php still refers to this setting.
Ref. #1964
There was a problem hiding this comment.
It does, but this piece of code if from the LegacyUpdater which would update things from older versions, so it doesn't need to be updated/maintained as long as it's not breaking anything.
However I forgot to write an update here to remove the file in existing config files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always use 'release' branch instead. Also treat commit hash as dev version
Fixes #1966