Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional variables are saved with plugins data #1550

Closed
ArthurHoaro opened this issue Sep 10, 2020 · 1 comment · Fixed by #1551
Closed

Additional variables are saved with plugins data #1550

ArthurHoaro opened this issue Sep 10, 2020 · 1 comment · Fixed by #1551
Assignees
@ArthurHoaro
Labels
bug it's broken! plugin bells and whistles
Milestone
0.12.0

Comments

@ArthurHoaro
Copy link
Member

Reported by @immanuelfodor

config.json.php:

"plugins": {
       "_BASE_PATH_": "",

The last variable seems extremely suspicious to me :)

I confirm that on my dev local environment I also have _LOGGEDIN_ and token under the plugins section which are not supposed to be here. I suspect that additional data are saved in PluginController.
@ArthurHoaro ArthurHoaro added the bug it's broken! label Sep 10, 2020
@ArthurHoaro ArthurHoaro added this to the 0.12.0 milestone Sep 10, 2020
@ArthurHoaro ArthurHoaro self-assigned this Sep 10, 2020
@ArthurHoaro ArthurHoaro added the plugin bells and whistles label Sep 10, 2020
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Sep 10, 2020
@ArthurHoaro
Plugins: do not save metadata along plugin parameters
0c10dd6 
Also prevent the token to be saved.

Fixes shaarli#1550
@ArthurHoaro ArthurHoaro mentioned this issue Sep 10, 2020
Merged
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Sep 10, 2020
@ArthurHoaro
Plugins: do not save metadata along plugin parameters
011dc9f 
Also prevent the token to be saved.

Fixes shaarli#1550
@immanuelfodor
Copy link

Hmm, so that one resulted in two issues at last 😃 (the other is #1548)

ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Sep 12, 2020
@ArthurHoaro
Plugins: do not save metadata along plugin parameters
4ff703e 
Also prevent the token to be saved.

Fixes shaarli#1550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArthurHoaro ArthurHoaro

Labels
bug it's broken! plugin bells and whistles
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Plugins: do not save metadata along plugin parameters ArthurHoaro/Shaarli
2 participants
@ArthurHoaro @immanuelfodor