Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Daily" view does not care for privacy #1543

Closed
gruenheit opened this issue Sep 5, 2020 · 2 comments · Fixed by #1547
Closed

"Daily" view does not care for privacy #1543

gruenheit opened this issue Sep 5, 2020 · 2 comments · Fixed by #1547
Labels
bug it's broken! security

Comments

@gruenheit
Copy link

gruenheit commented Sep 5, 2020 •
edited
Loading

Affected Version: Shaarli 0.12.0-beta, Theme: Default

HTD:

  • (preset) Import some bookmarks from another instance (here: Shaarli v0.11.1) with a couple of new created ones so that they will be displayed in the panel "Daily"

As long as you are logged in everything looks plausible when viewing the panel "Daily"

  • Change the visibility of the new created bookmarks to "private"
  • logout of shaarli
  • click to the view "Daily"

All the above bookmarks are displayed in the "Daily" view, even the ones marked as "private"
@nodiscc
Copy link
Member

nodiscc commented Sep 5, 2020

Confirmed on 0.12-0-beta (https://shaarli-next.hoa.ro/daily), not reproducible on 0.11.1

@nodiscc nodiscc added bug it's broken! security labels Sep 5, 2020
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Sep 6, 2020
@ArthurHoaro
Fix visibility issue on daily page
27ddfec 
This filter (links by day) didn't apply any visibility parameter.

Fixes shaarli#1543
@ArthurHoaro ArthurHoaro mentioned this issue Sep 6, 2020
Merged
@ArthurHoaro
Copy link
Member

Good catch, thank you for the report. It should be fixed by #1547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug it's broken! security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix visibility issue on daily page ArthurHoaro/Shaarli
3 participants
@ArthurHoaro @nodiscc @gruenheit