Make Colors.jl a direct dependency #107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Colors.jl is a weak dependency, and the user needs
using Colors
to enable ColorsExt extension, which sole purpose is to define_json_lower(c::Colorant)
.However, PlotlyBase.jl already has ColorSchemes.jl as a direct dependency and defines
_json_lower(::ColorScheme)
in the main module.But the latter method needs
_json_lower(::Colorant)
to work.So, making
Colors.jl
a direct dependency ofPlotlyBase.jl
would simplify things a bit. It would not increase the "dependencies burden" ofPlotlyBase.jl
sinceColors.jl
is already a direct dependency ofColorSchemes.jl
.Also, it should solve the error
which I am getting despite
using Colors
in my user project.