Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sphinx to fix build #1184

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Conversation

tomwhite
Copy link
Collaborator

@tomwhite tomwhite commented Feb 5, 2024

No description provided.

@tomwhite tomwhite added the upstream Used when our build breaks due to upstream changes label Feb 5, 2024
@tomwhite
Copy link
Collaborator Author

tomwhite commented Feb 5, 2024

The new doc packages won't install on Python 3.8. Since we don't need to build documentation on every Python version, I think the simplest way to fix this is to create a separate GitHub Actions workflow to check the documentation (check-docs.yml) which runs just on Python 3.9, and change build.yml that runs on all supported versions to just run the tests and upload coverage.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d8f5f3) 100.00% compared to head (ab4b956) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1184   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           52        52           
  Lines         5210      5210           
=========================================
  Hits          5210      5210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeromekelleher jeromekelleher added the auto-merge Auto merge label for mergify test flight label Feb 5, 2024
@mergify mergify bot merged commit a386541 into sgkit-dev:main Feb 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Auto merge label for mergify test flight upstream Used when our build breaks due to upstream changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants