Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component direct dependencies not installed #100

Closed
sgammon opened this issue Sep 3, 2023 · 0 comments · Fixed by #101 or #80
Closed

Component direct dependencies not installed #100

sgammon opened this issue Sep 3, 2023 · 0 comments · Fixed by #101 or #80
Assignees
@sgammon
Labels
bug Something isn't working components Issues relating to GraalVM components
Milestone
1.0.0

Comments

@sgammon
Copy link
Owner

sgammon commented Sep 3, 2023

When investigating #99, it was discovered that the effective_components installed as part of a components = [...] declaration only install the transitive dependencies, and not the actual requested dependencies. For example:

graalvm_repository(
  # ...
  components = [
    "js",
  ],
)

👆🏻 should install js, icu4j, regex, etc (the dependencies of js in addition to js), but instead, only icu4j and regex are installed, and js is not.
@sgammon sgammon added bug Something isn't working components Issues relating to GraalVM components labels Sep 3, 2023
@sgammon sgammon added this to the 1.0.0 milestone Sep 3, 2023
@sgammon sgammon self-assigned this Sep 3, 2023
@sgammon sgammon moved this to In Progress in GraalVM Rules for Bazel Sep 3, 2023
@sgammon sgammon mentioned this issue Sep 3, 2023
Merged
sgammon added a commit that referenced this issue Sep 3, 2023
@sgammon
fix: install requested components plus deps
b16859e 
- fix: add requested component to list of effective components
  installed via bindist

Fixes and closes #100. Thanks to
@mantasindrasius for reporting!

Relates-To: #100
Relates-To: #99
Signed-off-by: Sam Gammon <[email protected]>
@sgammon sgammon mentioned this issue Sep 3, 2023
Merged
sgammon added a commit that referenced this issue Sep 3, 2023
@sgammon
fix: install requested components plus deps
ef1cf4f 
- fix: add requested component to list of effective components
  installed via bindist

Fixes and closes #100. Thanks to
@mantasindrasius for reporting!

Relates-To: #100
Relates-To: #99
Signed-off-by: Sam Gammon <[email protected]>
@sgammon sgammon mentioned this issue Sep 3, 2023
Merged
@sgammon sgammon linked a pull request Sep 3, 2023 that will close this issue
Release: 0.10.x #80
Merged
sgammon added a commit that referenced this issue Sep 3, 2023
@sgammon
fix: install requested components plus deps
583c74b 
- fix: add requested component to list of effective components
  installed via bindist

Fixes and closes #100. Thanks to
@mantasindrasius for reporting!

Relates-To: #100
Relates-To: #99
Signed-off-by: Sam Gammon <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in GraalVM Rules for Bazel Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgammon sgammon

Labels
bug Something isn't working components Issues relating to GraalVM components
Projects
GraalVM Rules for Bazel
Status: Done
Milestone
1.0.0
1 participant
@sgammon