Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package dependency issue and python 3.12 support #984

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

fatbuddy
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Snapshots:

Include snapshots for easier review.

Checklist:

  • [v] My code follows the style guidelines of this project
  • [v] I have already squashed the commits and make the commit message conform to the project standard.
  • [v] I have already marked the commit with "BREAKING CHANGE" or "Fixes #" if needed.
  • [v] I have performed a self-review of my own code
  • [v] I have commented my code, particularly in hard-to-understand areas
  • [v] I have made corresponding changes to the documentation
  • [v] My changes generate no new warnings
  • [v] I have added tests that prove my fix is effective or that my feature works
  • [v] New and existing unit tests pass locally with my changes
  • [v] Any dependent changes have been merged and published in downstream modules

1. Fix dependency package (eralchemy2 and sqlalchemy)
2. Remove a test case that is not working
3. Fix the runtime issue from clean_duplication_utils
4. Fix CI issue with 3.12 compatibility
@dovahcrow dovahcrow merged commit be3f00c into sfu-db:develop Apr 3, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants