Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eda): fixed uncaught dtype exceptions #607

Merged
merged 1 commit into from
Apr 28, 2021
Merged

fix(eda): fixed uncaught dtype exceptions #607

merged 1 commit into from
Apr 28, 2021

Conversation

eutialia
Copy link
Member

Description

Fixed #604

How Has This Been Tested?

CI

Snapshots:

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have already squashed the commits and make the commit message conform to the project standard.
  • I have already marked the commit with "BREAKING CHANGE" or "Fixes #" if needed.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #607 (d301eb7) into develop (9cb11f4) will decrease coverage by 0.03%.
The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #607      +/-   ##
===========================================
- Coverage    83.48%   83.45%   -0.04%     
===========================================
  Files          102      102              
  Lines         9400     9409       +9     
===========================================
+ Hits          7848     7852       +4     
- Misses        1552     1557       +5     
Impacted Files Coverage Δ
dataprep/eda/create_report/formatter.py 93.37% <44.44%> (-2.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cb11f4...d301eb7. Read the comment docs.

@jinglinpeng jinglinpeng merged commit 5974094 into develop Apr 28, 2021
@jinglinpeng jinglinpeng deleted the fix/604 branch April 28, 2021 02:50
devinllu pushed a commit to devinllu/dataprep that referenced this pull request Nov 9, 2021
fix(eda): fixed uncaught dtype exceptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eda: issue with report on housing price datasets
2 participants