Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(clean): add docs for clean_country() #401

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

ryanwdale
Copy link
Contributor

Description

Added documentation for the clean_country and validate_country functions.

closes #398

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already squashed the commits and make the commit message conform to the project standard.
  • I have already marked the commit with "BREAKING CHANGE" or "Fixes #" if needed.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Added documentation for the clean_country and validate_country functions.

closes sfu-db#398
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #401 into develop will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #401      +/-   ##
===========================================
+ Coverage    74.18%   74.22%   +0.04%     
===========================================
  Files           65       65              
  Lines         4804     4804              
===========================================
+ Hits          3564     3566       +2     
+ Misses        1240     1238       -2     
Impacted Files Coverage Δ
dataprep/eda/distribution/render.py 68.35% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc8a2d9...2163981. Read the comment docs.

Copy link
Contributor

@brandonlockhart brandonlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well written, great job Ryan!

@brandonlockhart brandonlockhart merged commit f9d7b08 into sfu-db:develop Oct 28, 2020
devinllu pushed a commit to devinllu/dataprep that referenced this pull request Nov 9, 2021
docs(clean): add docs for clean_country()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

documentation for clean_country
2 participants