Code review #2679
Merged
Code review #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashNotAdam
commented
Jul 27, 2016
HashNotAdam
commented
- Create better conformity to the style guide.
- Create compatibility with the Code Climate version of RuboCop to stop pull requests from being incorrectly labeled as failed.
- Add RuboCop ignores for constants that are being used a mutable items since adjusting this behaviour would require a lot of testing.
- DRY up some code seen in multiple places.
added 30 commits
July 27, 2016 11:25
These methods are not aliases of each other and there are valid reasons for sometimes desiring alias_method
This was referenced Jul 27, 2016
| @@ -16,7 +16,7 @@ class PolymorphicAssociation < RailsAdmin::Config::Fields::Types::BelongsToAssoc | |||
| # association checks that any of the child models are included in | |||
| # configuration. | |||
| register_instance_option :visible? do | |||
| associated_model_config.length > 0 | |||
| !associated_model_config.empty? | |||
There was a problem hiding this comment.
I'll be honest with you... I didn't like this but also didn't take the time to look into what associated_model_config returned and so played it safe :)
Looking at it now, it seems like association.klass should always return an array so it should be safe to use any?
I'll make this change now.
|
👍 |
|
Excellent work, thanks a lot! |
|
Wonderful, thank you, I'll rebase my other PRs now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.