Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review #2679

Merged
merged 32 commits into from
Jul 29, 2016
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
6bb97ef
Replace nested if/else with elsif
Jul 27, 2016
41b9e3b
Upgrade rubocop for consistency with Code Climate
Jul 27, 2016
0f708f9
Replace fail with raise
Jul 27, 2016
80fa592
Remove unnecessary spacing
Jul 27, 2016
347f5d1
Replace nested if/else with elsif
Jul 27, 2016
dc46f86
Enforce trailing commas in arguments inline with existing code style
Jul 27, 2016
771d0c0
Replace length > 0 with !empty?
Jul 27, 2016
21c827e
Add trailing comma to arguments
Jul 27, 2016
7bb1788
Remove unnecessary interpolation
Jul 27, 2016
6c545d0
Remove redundant self
Jul 27, 2016
0cfc605
Disable enforcing of alias over alias_method
Jul 27, 2016
c94e36a
Freeze constants
Jul 27, 2016
aabff1d
Use return value of conditional for assignment
Jul 27, 2016
ff8c38d
Increase performance of string replacement
Jul 27, 2016
5ea2709
Remove useless access modifier
Jul 27, 2016
44f2e65
Replace empty case statement with if/elsif
Jul 27, 2016
b4f257d
DRY
Jul 27, 2016
174ba1e
Remove redundant disabling of Rubocop rules
Jul 27, 2016
db2bfce
Move repeated inspect logic into shared class
Jul 27, 2016
e02cb2a
Outdent access modifier
Jul 27, 2016
3077c0e
Remove redundant merge
Jul 27, 2016
1b7937b
Remove nested modifier
Jul 27, 2016
06dd59a
Variables have been incorrectly defined like constants but are actual…
Jul 27, 2016
6a129ec
Replace times.collect with Array.new for better performance
Jul 27, 2016
8acbccd
Ignore ConstantName warnings
Jul 27, 2016
cd2cb33
Consistent alignment of opening and closing braces
Jul 27, 2016
d91d813
Variable incorrectly defined like a constant is actually mutable
Jul 27, 2016
2d66c8c
Remove parentheses around method calls
Jul 27, 2016
72edcb9
Update rubocop for compatibility with Code Climate
Jul 27, 2016
5a960f7
Update rubocop in gemfiles so CI is in sync with Code Climate
Jul 27, 2016
3fcf5d9
Replace !empty? with any?
Jul 29, 2016
c02ca4e
Replace Array.new(\d) with FactoryGirl.create_list
Jul 29, 2016
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update rubocop for compatibility with Code Climate
Adam Rice authored and Adam Rice committed Jul 27, 2016
commit 72edcb9abbf09783f017aa39336e2babc86f50bf
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
@@ -43,7 +43,7 @@ group :test do
gem 'pundit'
gem 'rack-cache', require: 'rack/cache'
gem 'rspec-rails', '>= 2.14'
gem 'rubocop', '~> 0.40.0'
gem 'rubocop', '~> 0.41.2'
gem 'simplecov', '>= 0.9', require: false
gem 'timecop', '>= 0.5'