Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recenter if map marker is obscured by other elements #264

Merged
merged 8 commits into from
Nov 14, 2024

Conversation

nickvisut
Copy link
Collaborator

@nickvisut nickvisut commented Oct 30, 2024

This PR addresses the issue where a map marker could be overlapped by the school details pane that overlaps the map on mobile. We now attempt to detect if the selected map marker (school) is obscured and center it if so.

Closes #265

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
support-sfusd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 1:09am

Copy link
Collaborator

@mattgianni mattgianni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Copy link
Collaborator

@BeeSeeWhy BeeSeeWhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@BeeSeeWhy BeeSeeWhy merged commit f4a59f2 into develop Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Selected school's map marker can be obscured by school detail card (on mobile)
3 participants