Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Map autocenters on school click/focus #259

Closed
nickvisut opened this issue Oct 10, 2024 · 1 comment · May be fixed by #260
Closed

[Bug]: Map autocenters on school click/focus #259

nickvisut opened this issue Oct 10, 2024 · 1 comment · May be fixed by #260
Assignees
Labels
bug Something isn't working

Comments

@nickvisut
Copy link
Collaborator

nickvisut commented Oct 10, 2024

What happened?

When a user clicks on a school on the map, the map will autocenter that school. This is somewhat unexpected on desktop web, and more jarring on mobile.

This also happens when keyboard navigating (eg TAB key) to OR selecting a school from the search filter when it's still in the map's visible area, which is similarly unexpected.

What should have happened instead?

When a user clicks on a school on the map, the map should not autocenter or pan at all.*

If the user keyboard navigates to a school OR selects a school from the search filter, however, we should still autocenter/pan to it if it's not currently in the map's visible area or it's obscured by another UI element.

*Arguably, it does make sense to pan if the map marker is at the very edge of the map, especially if it's cut off. However, we are not addressing that unhappy path case in this bug.

Version

supportsfschools.org (Production)

@nickvisut
Copy link
Collaborator Author

nickvisut commented Oct 31, 2024

This has been fixed on main. However, a new issue was identified in which a school marker can still be obscured by other elements (in particular, the school detail card on mobile).

That issue will be accounted for in new PR #264.

@github-project-automation github-project-automation bot moved this from In Review to Done in Support SFUSD Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants