Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: pull in JS updates re tab display from catalog #14

Merged
merged 6 commits into from
Apr 19, 2023

Conversation

jsheunis
Copy link
Collaborator

@jsheunis jsheunis commented Apr 18, 2023

This PR pulls in updates from catalog, including:

@jsheunis jsheunis marked this pull request as draft April 18, 2023 22:59
@jsheunis
Copy link
Collaborator Author

Ok looks like it skips publications tab and goes to Funding. Will investigate this first.

@jsheunis jsheunis marked this pull request as ready for review April 19, 2023 10:58
@jsheunis
Copy link
Collaborator Author

Ok looks like it skips publications tab and goes to Funding. Will investigate this first.

This was because the publications tab took longer to load, so by the time the code ran for setting the tabindex, the publications tab didn't exist yet on the DOM. This was accounted for in 231bf92. This fix needs to be fed back in to datalad-catalog.

@mslw mslw merged commit b43135a into sfb1451:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove gitsha "version" from cards in subdataset list
2 participants