Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more x509 extension helper functions #1887

Merged
merged 6 commits into from
Apr 24, 2023
Merged

Conversation

zh-jq
Copy link
Contributor

@zh-jq zh-jq commented Apr 18, 2023

openssl/src/x509/mod.rs Outdated Show resolved Hide resolved
@sfackler
Copy link
Owner

Can you add a test for these methods?

@zh-jq
Copy link
Contributor Author

zh-jq commented Apr 23, 2023

I didn't found any certs with authority_issuer and authority_serial set, not even in the openssl tests. So should we keep them without tests?

@alex
Copy link
Collaborator

alex commented Apr 23, 2023 via email

@zh-jq
Copy link
Contributor Author

zh-jq commented Apr 23, 2023

yes, found one and updated

@sfackler sfackler merged commit 33a610f into sfackler:master Apr 24, 2023
@sfackler
Copy link
Owner

Thanks!

@zh-jq zh-jq deleted the x509_ext branch May 8, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants