Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PKey::public_eq can leave errors on the stack #1884

Closed
alex opened this issue Apr 16, 2023 · 0 comments
Closed

PKey::public_eq can leave errors on the stack #1884

alex opened this issue Apr 16, 2023 · 0 comments

Comments

@alex
Copy link
Collaborator

alex commented Apr 16, 2023

https://docs.rs/openssl/latest/openssl/pkey/struct.PKeyRef.html#method.public_eq

If the keys are different types, an error will be left on the stack.
alex added a commit to alex/rust-openssl that referenced this issue Apr 16, 2023
@alex
Fixes sfackler#1884 -- don't leave an error on the stack in public_eq
eb2a76b
sfackler added a commit that referenced this issue Apr 16, 2023
@sfackler
Merge pull request #1885 from alex/cmp-error-stack
bdb165b 
Fixes #1884 -- don't leave an error on the stack in public_eq
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alex