This repository has been archived by the owner on Jun 5, 2020. It is now read-only.
Allow [patch] to change the sourceID but still appear in tree #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay! I spent a while trying to figure out why patched dependencies disappeared but never could. This should fix #27. |
|
No problem, thanks for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[patch](unlike[replace]) occurs before dependency resolution (or maybe during) so that the patched dependency appears inresolve.deps_not_replaced().Since a patched dependency can have (and often will have) a separate source_id (e.g. git instead of crates.io) it seems to make sense to compare them to the
pkg.dependencies()in a way that ignores the source.Without this change,
[patch]ed dependencies just disappear from the tree silently, which is a little surprising 👻.(Change also includes a
cargo update- full disclosure)