Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We faced the issue when the
SCAN
command returned too big value forlong long
type which led to the errorInvalid cursor reply: 9286422431637963776
. This happened with AWS ElastiCache (Redis). According to the documentation:Also, the same issue was fixed for Spring: spring-projects/spring-data-redis#2796
I realize this change is quite big and probably a braking change, but I believe we need to fix it. So I replaced all
long long
cursors withCursor
alias which isunsigned long long
. Probably it's better to usestd::uint64_t
to be more precise.