Skip to content

Commit

Permalink
fix @wingunder's comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sewenew committed Nov 13, 2019
1 parent 10ca2b2 commit 10c333d
Showing 1 changed file with 17 additions and 12 deletions.
29 changes: 17 additions & 12 deletions src/sw/redis++/recipes/redlock.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,20 @@ std::chrono::milliseconds RedMutex::try_lock(const std::string &val,
const std::chrono::milliseconds &ttl) {
auto start = std::chrono::steady_clock::now();

auto lock_ok = _try_lock(val, ttl);
if (!_try_lock(val, ttl)) {
// Failed to lock more than half masters.
unlock(_resource);

return std::chrono::milliseconds(-1);
}

auto stop = std::chrono::steady_clock::now();
auto elapse = stop - start;

auto time_left = std::chrono::duration_cast<std::chrono::milliseconds>(ttl - elapse);

if (!lock_ok || time_left < std::chrono::milliseconds(0)) {
// Failed to lock more than half masters, or no time left for the lock.
if (time_left <= std::chrono::milliseconds(0)) {
// No time left for the lock.
unlock(_resource);

return std::chrono::milliseconds(-1);
}

return time_left;
Expand All @@ -69,17 +71,20 @@ std::chrono::milliseconds RedMutex::extend_lock(const std::string &val,
}

auto lock_ok = lock_cnt >= _quorum();
if (!lock_ok) {
// Failed to lock more than half masters.
unlock(_resource);

return std::chrono::milliseconds(-1);
}

auto stop = std::chrono::steady_clock::now();
auto elapse = stop - start;

auto time_left = std::chrono::duration_cast<std::chrono::milliseconds>(ttl - elapse);

if (!lock_ok || time_left < std::chrono::milliseconds(0)) {
// Failed to lock more than half masters, or no time left for the lock.
if (time_left <= std::chrono::milliseconds(0)) {
// No time left for the lock.
unlock(_resource);

return std::chrono::milliseconds(-1);
}

return time_left;
Expand Down Expand Up @@ -161,7 +166,7 @@ bool RedMutex::_try_lock_master(Redis &master,
std::chrono::milliseconds RedLockUtils::ttl(const SysTime &tp) {
auto cur = std::chrono::system_clock::now();
auto ttl = tp - cur;
if (ttl.count() < 0) {
if (ttl.count() <= 0) {
throw Error("time already pasts");
}

Expand Down

0 comments on commit 10c333d

Please sign in to comment.