fix: re-simplification works

seung-lab · Nov 2, 2023 · e1966c9 · e1966c9
1 parent 9b2970e
commit e1966c9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/cMesher.hpp b/cMesher.hpp
@@ -198,7 +198,8 @@ class CMesher {
       triangles, 
       generate_normals, 
       simplification_factor, 
-      max_simplification_error
+      max_simplification_error,
+      false
     );
   }
 

diff --git a/zmesh/_zmesh.pyx b/zmesh/_zmesh.pyx
@@ -241,7 +241,7 @@ class Mesher:
 
     Returns: Mesh
     """
-    mesher = new CMesher[uint64_t, uint64_t, float](self.voxel_res)
+    mesher = new CMesher[uint64_t, uint64_t, float]((1,1,1))
 
     cdef size_t ti = 0
     cdef size_t vi = 0
@@ -252,6 +252,8 @@ class Mesher:
       (triangles.shape[0], 3), dtype=np.uint64, order='C'
     ) 
 
+    max_error //= np.sqrt(np.sum(self.voxel_res ** 2))
+
     triangles /= self.voxel_res
     triangles *= 2.0
     cdef float min_vertex = np.min(triangles)
@@ -285,7 +287,7 @@ class Mesher:
       for i in range(len(result.points)):
         result.points[i] += min_vertex
 
-    return self._normalize_simplified_mesh(result, voxel_centered, physical=True)
+    return self._normalize_simplified_mesh(result, voxel_centered, physical=False)
 
   def clear(self):
     self._mesher.clear()