chore: reduce memory usage of webpack #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webpack for build-min is called with --max_old_space_size=2048 which seems to make travis work again, but we don't know exactly what this flag is doing, and what was the default value that we were using. nodejs/node#7937 This commit also clean some vestigial code from .travis.yaml that is not needed now that we test inside the docker container.
|
Here's some info on the --max_old_space_size flag: |
manuel-castro
pushed a commit
that referenced
this pull request
Sep 9, 2019
chore: Fix appveyor setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpack for build-min is called with --max_old_space_size=2048
which seems to make travis work again, but we don't know
exactly what this flag is doing, and what was the default
value that we were using.
nodejs/node#7937
This commit also clean some vestigial code from .travis.yaml that
is not needed now that we test inside the docker container.