Only use OsLookuper for default variables #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @NeonWizard - this is working as intended. The point of overriding the lookupper is for testing purposes. |
wut? This is fixing issue #85 where you yourself said this would be a good fix |
|
No, in #85 I said that we should not inherit the prefix, but that any change would be a breaking API change that would need to wait. |
I'm not sure I understand. Is there a different branch or somewhere else this PR should be targeting? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in this issue (#85), it's confusing to use anything other than the OsLookuper for default variables. This PR changes the default variable lookuper from using the same one as the actual variable to only using the OsLookuper.