Add a gesture to open up a context menu; fix quitting #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A better version of this gesture would include head pose. I think the original suggested gesture was "looking at the palm of your hand", perhaps with the hand pointing upwards. |
jdm
approved these changes
Mar 30, 2020
webxr/openxr/input.rs
Outdated
| InputFrame, | ||
| /* clicked */ Option<SelectEvent>, | ||
| /* squeezed */ Option<SelectEvent>, | ||
| /* menu_selected */ bool, |
There was a problem hiding this comment.
Returning a real structure with named fields might be useful at this point.
webxr/openxr/input.rs
Outdated
| let mut menu_selected = false; | ||
| // Check if the palm is facing up. This is our "menu" gesture. | ||
| if let Some(grip_origin) = grip_origin { | ||
| // The X axis of the grip is perpendicular to the palm, however it's |
webxr/openxr/input.rs
Outdated
| -1.0 | ||
| }; | ||
|
|
||
| // Rotate it by the grip to btain the desired vector |
webxr/openxr/input.rs
Outdated
| // close to 1 | ||
| if angle > 0.9 { | ||
| self.menu_gesture_sustain += 1; | ||
| if self.menu_gesture_sustain > 60 { |
There was a problem hiding this comment.
Should we make this a named constant?
webxr/openxr/mod.rs
Outdated
| @@ -65,19 +65,58 @@ pub trait SurfaceProviderRegistration: Send { | |||
| fn clone(&self) -> Box<dyn SurfaceProviderRegistration>; | |||
| } | |||
|
|
|||
| /// | |||
There was a problem hiding this comment.
/// Provides a way to interact with context menus.
Manishearth
force-pushed
the
menu-gesture
branch
from
1bec1a8
to
20408f2
Compare
|
@bors-servo r=jdm |
|
📌 Commit 20408f2 has been approved by |
bors-servo
added a commit
that referenced
this pull request
Mar 30, 2020
Add a gesture to open up a context menu; fix quitting This adds a gesture (currently: "palm facing upwards") to open up a context menu. servo side: servo/servo#26051 r? @jdm
|
💔 Test failed - checks-travis |
Manishearth
force-pushed
the
menu-gesture
branch
from
20408f2
to
1557ec4
Compare
|
@bors-servo r=jdm |
|
📌 Commit 1557ec4 has been approved by |
bors-servo
added a commit
that referenced
this pull request
Mar 30, 2020
Add a gesture to open up a context menu; fix quitting This adds a gesture (currently: "palm facing upwards") to open up a context menu. servo side: servo/servo#26051 r? @jdm
Manishearth
force-pushed
the
menu-gesture
branch
from
1557ec4
to
8a53399
Compare
|
@bors-servo r=jdm |
|
📌 Commit 8a53399 has been approved by |
|
☀️ Test successful - checks-travis |
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Mar 30, 2020
Hook up new openxr context menu gesture to embedder context menu machinery Based on #26043 Fixes #25797, #26057 servo/webxr#144 needs to land first Currently when exited the Servo window is blurred, apparently we need to call `Window.Activate` on it. r? @jdm cc @paulrouget
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Mar 31, 2020
Hook up new openxr context menu gesture to embedder context menu machinery Based on #26043 Fixes #25797, #26057 servo/webxr#144 needs to land first Currently when exited the Servo window is blurred, apparently we need to call `Window.Activate` on it. r? @jdm cc @paulrouget
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Mar 31, 2020
Hook up new openxr context menu gesture to embedder context menu machinery Based on #26043 Fixes #25797, #26057 servo/webxr#144 needs to land first Currently when exited the Servo window is blurred, apparently we need to call `Window.Activate` on it. r? @jdm cc @paulrouget
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Mar 31, 2020
Hook up new openxr context menu gesture to embedder context menu machinery Based on #26043 Fixes #25797, #26057 servo/webxr#144 needs to land first Currently when exited the Servo window is blurred, apparently we need to call `Window.Activate` on it. r? @jdm cc @paulrouget
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Mar 31, 2020
Hook up new openxr context menu gesture to embedder context menu machinery Based on #26043 Fixes #25797, #26057 servo/webxr#144 needs to land first Currently when exited the Servo window is blurred, apparently we need to call `Window.Activate` on it. r? @jdm cc @paulrouget
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Apr 1, 2020
Hook up new openxr context menu gesture to embedder context menu machinery Based on #26043 Fixes #25797, #26057 servo/webxr#144 needs to land first Currently when exited the Servo window is blurred, apparently we need to call `Window.Activate` on it. r? @jdm cc @paulrouget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a gesture (currently: "palm facing upwards") to open up a context menu.
servo side: servo/servo#26051
r? @jdm