-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use panic=abort instead of panic=unwind #1825
Conversation
This is the same mode as Gecko uses and will get better codegen once rust-lang/rust#45012 has landed.
What does that imply for other users of webrender? |
They will get worse performance until Rust supports emitting noalias metadata in code that can unwind. Although even then, having to unwind will always constrain the optimizer. |
I think the top crate wins, so servo will choose to ignore this directive. However this will make wrench use panic=abort. |
Actually I think servo/gecko won't see this at all, since it's in the workspace, and not the crates. |
@gankro Ok, I thought that this would set |
Yeah I totally get it, but it should be fine? |
I confirmed in a local servo build that a panic in WR doesn't abort the process with this change, so I'm assuming that means it's OK to merge. @bors-servo r+ |
📌 Commit 6af8c83 has been approved by |
Use panic=abort instead of panic=unwind This is the same mode as Gecko uses and will get better codegen once rust-lang/rust#45012 has landed. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1825) <!-- Reviewable:end -->
☀️ Test successful - status-appveyor, status-travis |
This is the same mode as Gecko uses and will get better codegen
once rust-lang/rust#45012 has landed.
This change is