Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the URL port setter tests #14126

Merged
merged 1 commit into from
Nov 8, 2016
Merged

Fix the URL port setter tests #14126

merged 1 commit into from
Nov 8, 2016

Conversation

nox
Copy link
Contributor

@nox nox commented Nov 8, 2016 •
edited by larsbergstrom
Loading

This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 8, 2016
@nox nox force-pushed the url-port-setter branch from e18263d to ebe5f85 Compare November 8, 2016 08:29
@nox
Copy link
Contributor Author

nox commented Nov 8, 2016

<•SimonSapin> nox: r+ with whatwg/url#113 added to the commit message

@bors-servo r=SimonSapin

@bors-servo
Copy link
Contributor

📌 Commit ebe5f85 has been approved by SimonSapin

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 8, 2016
@highfive highfive assigned SimonSapin and unassigned asajeffrey Nov 8, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit ebe5f85 with merge 8cd5216...

bors-servo pushed a commit that referenced this pull request Nov 8, 2016
Auto merge of #14126 - nox:url-port-setter, r=SimonSapin
8cd5216 
Fix the URL port setter tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14126)
<!-- Reviewable:end -->
@SimonSapin
Copy link
Member

r+ with whatwg/url#113 in the commit message.

@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

@bors-servo bors-servo merged commit ebe5f85 into servo:master Nov 8, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 8, 2016
@nox nox deleted the url-port-setter branch November 8, 2016 09:34
@Ms2ger Ms2ger mentioned this pull request Nov 14, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nox @bors-servo @SimonSapin @asajeffrey @highfive