Update Rust MSRV to 1.45 #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
force-pushed
the
bump_msrv
branch
from
59bd672 to
ba3da3d
Compare
madsmtm
approved these changes
Jan 31, 2022
lucacasonato
force-pushed
the
bump_msrv
branch
from
fc8f4ae to
52d736e
Compare
valenting
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The earliest Rust version with all of the standard library features we'd like to make use of is 1.45. The only feature this does not have yet is
edition = 2021, but other than looking nice, that would have no effect onrust-urlanyway.I recommend we bump the MSRV to 1.45 instead of 1.56 then, to minimize breakage across the ecosystem.
Closes #745