Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-idempotent serialization for ./ and ../ paths (fixes #601) #629

Closed
wants to merge 2 commits into from

Conversation

djc
Copy link
Contributor

@djc djc commented Aug 24, 2020

No description provided.

@valenting
Copy link
Collaborator

I think I didn't handle the code path for the setters 🤔

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably d7dab15) made this pull request unmergeable. Please resolve the merge conflicts.

@annevk
Copy link

annevk commented Aug 25, 2020

In the standard this ended up impacting the URL serializer exclusively. It would surprise me a bit of all the parser changes here were needed.

@valenting
Copy link
Collaborator

In the standard this ended up impacting the URL serializer exclusively. It would surprise me a bit of all the parser changes here were needed.

rust-url builds the serialization as it parses the input.
For speed mostly. This way serializing is just returning a reference to the serialization which is just one string - no allocations.

@djc djc mentioned this pull request Oct 19, 2020
@djc djc closed this Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants