impl TryFrom<'a str> for Url #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoshua Wuyts <[email protected]>
|
It seems the build is failing for reasons unrelated to this patch. |
url now requires Rust 1.36 which means a feature flag is now redundant.
|
Updated to remove the feature flag since the minimum required Rust version for the crate is now 1.36, and the minimum required version for this patch is 1.34 🎉 |
|
@valenting if you have time, could you perhaps take a look at this PR? Landing this would be a great help for several of our libraries. |
|
@valenting would it be possible to publish a new release in the near future that includes this change? We're excited to use it! |
yoshuawuyts
added a commit
to http-rs/http-types
that referenced
this pull request
May 13, 2020
We're waiting on servo/rust-url#569 to be published for URL shorthands to be practical; but once it lands it should be really nice to use
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #568. Implements
TryFrom<'a str> for Urlgated behind thetry_fromfeature. This should make it possible to use this conversion without issuing a breaking change. Thanks!