Restore implementation for ToSocketAddrs #533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
url::Url's ToSocketAddrs implementation was dropped because of its large API surface. Restore it with a simpler implementation that does not introduce as much API surface. The upside is that the HostAndPort and SocketAddrs helper types are no longer necessary. The downside is that if the URL specifies an IP address, the ToSocketAddrs implementation has to parse the IP address from a string again.
bors-servo
pushed a commit
that referenced
this pull request
Aug 5, 2019
Restore DNS resolution functionality from url 1.x This is an alternative to #533. I feel that an inherent method is more appropriate than an impl of the `ToSocketAddrs` trait: it is not the URL as a whole that is converted, only parts of it. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/535) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought of this while writing up #532.
url::Url's ToSocketAddrs implementation was dropped because of its large
API surface. Restore it with a simpler implementation that does not
introduce as much API surface. The upside is that the HostAndPort and
SocketAddrs helper types are no longer necessary. The downside is that
if the URL specifies an IP address, the ToSocketAddrs implementation has
to parse the IP address from a string again.
This change is