Avoid reparse issues with non-special URLs #459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zealousidealroll
force-pushed
the
fix-397
branch
4 times, most recently
from
b044e53
to
f5cd38e
Compare
|
Does this behavior match https://url.spec.whatwg.org/#url-parsing ? |
zealousidealroll
force-pushed
the
fix-397
branch
2 times, most recently
from
a9c7af5
to
59ad1a9
Compare
This is a willfull violation of the URL specification for serialization. It retains spec-compliance for parsing, it aligns with the behavior of Microsoft Edge, and it "fixes" an acknowledged specification bug. See whatwg/url#415 Fixes servo#397
zealousidealroll
force-pushed
the
fix-397
branch
from
59ad1a9
to
c53bab5
Compare
|
I fixed it so that it complies with the specification for parsing. It wasn't compliant for parsing but it is now. It still has to violate the spec for serialization, because rust-url's whole mode of operation assumes that URLs can be round-trip reparsed, and there's a bug in the spec that makes that not work. This change causes rust-url to behave the same way as Microsoft Edge (and I assume whatever C++-based parser it uses under the hood). |
zealousidealroll
changed the title
// when there's no host
|
☔ The latest upstream changes (presumably #537) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a contradiction where the URL starts out with no host, but gets normalized into a URL where the first part of a path is interpreted as the host.
Fixes #397
This is a willfull violation of the URL specification for serialization. It retains spec-compliance for parsing, it aligns with the behavior of Microsoft Edge, and it "fixes" an acknowledged specification bug.
See whatwg/url#415
This change is