Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cargo): Update minimum matches crate version that compiles #441

Closed
wants to merge 1 commit into from

Conversation

klausi
Copy link

@klausi klausi commented Mar 18, 2018

While working on a minimum cargo dependency installer I noticed that this crate does not compile with matches 0.1.0.

cargo update -Z minimal-versions
    ...
    Updating matches v0.1.6 -> v0.1.0
    ...
cargo build
   Compiling matches v0.1.0
error: macros that expand to items must either be surrounded with braces or followed by a semicolon
  --> /home/klausi/.cargo/registry/src/github.com-1ecc6299db9ec823/matches-0.1.0/lib.rs:4:21
   |
4  |   macro_rules! matches(
   |  _____________________^
5  | |     ($expression: expr, $($pattern:pat)|+) => (
6  | |         matches!($expression, $($pattern)|+ if true)
7  | |     );
...  |
13 | |     );
14 | | )
   | |_^

error: aborting due to previous error

error: Could not compile `matches`.

This change is Reviewable

@SimonSapin
Copy link
Member

This is an issue in matches, not in url. 0.1.0 doesn’t compile on recent Rust versions, and 0.1.1 doesn’t compile on the stable channel. I’ve "yanked" them from crates.io, they should now be ignored by Cargo unless already selected in a Cargo.lock file.

@SimonSapin SimonSapin closed this Mar 18, 2018
@klausi
Copy link
Author

klausi commented Mar 23, 2018

Thanks, that also works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants