Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rustdoc for feature query_encoding on docs.rs #427

Merged
merged 1 commit into from
Jan 21, 2018

Conversation

dekellum
Copy link
Contributor

@dekellum dekellum commented Jan 19, 2018

So that ParseOptions::encoding_override shows up on docs.rs This relates to and was requested by me in #308. I believe this is how to implement.

See onur/docs.rs@62fdcf605 for the docs.rs support of this config.


This change is Reviewable

@SimonSapin
Copy link
Member

Looks good, thanks.

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 72b7ff9 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit 72b7ff9 with merge 0f0813f...

bors-servo pushed a commit that referenced this pull request Jan 21, 2018
Enable rustdoc for feature query_encoding on docs.rs

So that ParseOptions::encoding_override shows up on docs.rs  This relates to and was requested by me in #308.  I believe this is how to implement.

See onur/docs.rs@62fdcf605 for the docs.rs support of this config.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/427)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: SimonSapin
Pushing 0f0813f to master...

@bors-servo bors-servo merged commit 72b7ff9 into servo:master Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants